From cad433eff9745194f57313e14d0b950df4cd7ac1 Mon Sep 17 00:00:00 2001 From: lonyele Date: Tue, 4 Jun 2019 22:40:16 +0900 Subject: [PATCH 1/4] Fix links that are not working with plain left click --- addons/notes/src/Panel.tsx | 2 ++ lib/components/src/placeholder/placeholder.stories.tsx | 5 ++++- lib/ui/src/settings/about.js | 2 ++ 3 files changed, 8 insertions(+), 1 deletion(-) diff --git a/addons/notes/src/Panel.tsx b/addons/notes/src/Panel.tsx index aa4f98eae219..70ea94f33e9f 100644 --- a/addons/notes/src/Panel.tsx +++ b/addons/notes/src/Panel.tsx @@ -149,6 +149,8 @@ const NotesPanel = ({ active }: Props) => { href="https://github.com/storybooks/storybook/tree/master/addons/notes" target="_blank" withArrow + secondary + cancel={false} > document components in Markdown diff --git a/lib/components/src/placeholder/placeholder.stories.tsx b/lib/components/src/placeholder/placeholder.stories.tsx index 7994dbe11e74..0c30e6cb6f42 100644 --- a/lib/components/src/placeholder/placeholder.stories.tsx +++ b/lib/components/src/placeholder/placeholder.stories.tsx @@ -15,7 +15,10 @@ export const twoChildren = () => ( This has two children, the first bold - The second normal weight. Here's a link + The second normal weight. Here's a{' '} + + link + ); diff --git a/lib/ui/src/settings/about.js b/lib/ui/src/settings/about.js index fb57ab2b6ccf..2459cbcbd7e0 100644 --- a/lib/ui/src/settings/about.js +++ b/lib/ui/src/settings/about.js @@ -168,6 +168,8 @@ const AboutScreen = ({ latest, current, onClose }) => { href="https://github.com/storybooks/storybook/releases" target="_blank" withArrow + secondary + cancel={false} > Check Storybook's release history From e035a730c0b7c9e39ad93cf02a35d4ccb775f2bc Mon Sep 17 00:00:00 2001 From: lonyele Date: Tue, 4 Jun 2019 22:54:44 +0900 Subject: [PATCH 2/4] Fix code formatting --- lib/components/src/placeholder/placeholder.stories.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/components/src/placeholder/placeholder.stories.tsx b/lib/components/src/placeholder/placeholder.stories.tsx index 0c30e6cb6f42..63a8f45a18c5 100644 --- a/lib/components/src/placeholder/placeholder.stories.tsx +++ b/lib/components/src/placeholder/placeholder.stories.tsx @@ -15,7 +15,7 @@ export const twoChildren = () => ( This has two children, the first bold - The second normal weight. Here's a{' '} + The second normal weight. Here's a link From 13e42fd0fae8de2b3c740d189e2846e4d7d846b4 Mon Sep 17 00:00:00 2001 From: lonyele Date: Tue, 4 Jun 2019 23:27:33 +0900 Subject: [PATCH 3/4] Fix mistake --- lib/components/src/placeholder/placeholder.stories.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/components/src/placeholder/placeholder.stories.tsx b/lib/components/src/placeholder/placeholder.stories.tsx index 63a8f45a18c5..0c30e6cb6f42 100644 --- a/lib/components/src/placeholder/placeholder.stories.tsx +++ b/lib/components/src/placeholder/placeholder.stories.tsx @@ -15,7 +15,7 @@ export const twoChildren = () => ( This has two children, the first bold - The second normal weight. Here's a + The second normal weight. Here's a{' '} link From ddad0469771c2dd65763d1b4159431201f8a7d0e Mon Sep 17 00:00:00 2001 From: Norbert de Langen Date: Thu, 6 Jun 2019 13:45:04 +0200 Subject: [PATCH 4/4] FIX snapshots --- .../__snapshots__/storyshots.test.js.snap | 42 ++++++++++ .../__snapshots__/about.stories.storyshot | 76 +++++-------------- 2 files changed, 59 insertions(+), 59 deletions(-) diff --git a/examples/official-storybook/tests/__snapshots__/storyshots.test.js.snap b/examples/official-storybook/tests/__snapshots__/storyshots.test.js.snap index 6da1f644e7f3..218a95fbb3ba 100644 --- a/examples/official-storybook/tests/__snapshots__/storyshots.test.js.snap +++ b/examples/official-storybook/tests/__snapshots__/storyshots.test.js.snap @@ -2420,6 +2420,7 @@ exports[`Storyshots Basics|Placeholder twoChildren 1`] = ` -webkit-text-decoration: none; text-decoration: none; color: #1EA7FD; + color: #999999; } .emotion-2 svg path { @@ -2455,6 +2456,26 @@ exports[`Storyshots Basics|Placeholder twoChildren 1`] = ` margin-right: 0.4em; } +.emotion-2 svg path { + fill: #999999; +} + +.emotion-2:hover { + color: #666666; +} + +.emotion-2:hover svg path { + fill: #666666; +} + +.emotion-2:active { + color: #444444; +} + +.emotion-2:active svg path { + fill: #444444; +} + .emotion-4 { padding: 30px; text-align: center; @@ -2473,6 +2494,7 @@ exports[`Storyshots Basics|Placeholder twoChildren 1`] = ` -webkit-text-decoration: none; text-decoration: none; color: #1EA7FD; + color: #999999; } .emotion-2 svg path { @@ -2508,6 +2530,26 @@ exports[`Storyshots Basics|Placeholder twoChildren 1`] = ` margin-right: 0.4em; } +.emotion-2 svg path { + fill: #999999; +} + +.emotion-2:hover { + color: #666666; +} + +.emotion-2:hover svg path { + fill: #666666; +} + +.emotion-2:active { + color: #444444; +} + +.emotion-2:active svg path { + fill: #444444; +} +
diff --git a/lib/ui/src/settings/__snapshots__/about.stories.storyshot b/lib/ui/src/settings/__snapshots__/about.stories.storyshot index 2ded1a62284e..5361f7c4635c 100644 --- a/lib/ui/src/settings/__snapshots__/about.stories.storyshot +++ b/lib/ui/src/settings/__snapshots__/about.stories.storyshot @@ -195,48 +195,6 @@ exports[`Storyshots UI|Settings/AboutScreen failed to fetch new version 1`] = ` width: 15px; } -.emotion-14 { - display: inline-block; - -webkit-transition: all 150ms ease-out; - transition: all 150ms ease-out; - -webkit-text-decoration: none; - text-decoration: none; - color: #1EA7FD; -} - -.emotion-14 svg path { - fill: #1EA7FD; -} - -.emotion-14:hover, -.emotion-14:focus { - cursor: pointer; - color: #0297f5; -} - -.emotion-14:hover svg path, -.emotion-14:focus svg path { - fill: #0297f5; -} - -.emotion-14:active { - color: #028ee6; -} - -.emotion-14:active svg path { - fill: #028ee6; -} - -.emotion-14 svg { - display: inline-block; - height: 1em; - width: 1em; - vertical-align: text-top; - position: relative; - bottom: -0.125em; - margin-right: 0.4em; -} - .emotion-22 { display: -webkit-box; display: -webkit-flex; @@ -252,7 +210,7 @@ exports[`Storyshots UI|Settings/AboutScreen failed to fetch new version 1`] = ` margin-left: 20px; } -.emotion-17 { +.emotion-14 { display: inline-block; -webkit-transition: all 150ms ease-out; transition: all 150ms ease-out; @@ -262,30 +220,30 @@ exports[`Storyshots UI|Settings/AboutScreen failed to fetch new version 1`] = ` color: #999999; } -.emotion-17 svg path { +.emotion-14 svg path { fill: #1EA7FD; } -.emotion-17:hover, -.emotion-17:focus { +.emotion-14:hover, +.emotion-14:focus { cursor: pointer; color: #0297f5; } -.emotion-17:hover svg path, -.emotion-17:focus svg path { +.emotion-14:hover svg path, +.emotion-14:focus svg path { fill: #0297f5; } -.emotion-17:active { +.emotion-14:active { color: #028ee6; } -.emotion-17:active svg path { +.emotion-14:active svg path { fill: #028ee6; } -.emotion-17 svg { +.emotion-14 svg { display: inline-block; height: 1em; width: 1em; @@ -295,23 +253,23 @@ exports[`Storyshots UI|Settings/AboutScreen failed to fetch new version 1`] = ` margin-right: 0.4em; } -.emotion-17 svg path { +.emotion-14 svg path { fill: #999999; } -.emotion-17:hover { +.emotion-14:hover { color: #666666; } -.emotion-17:hover svg path { +.emotion-14:hover svg path { fill: #666666; } -.emotion-17:active { +.emotion-14:active { color: #444444; } -.emotion-17:active svg path { +.emotion-14:active svg path { fill: #444444; } @@ -543,7 +501,7 @@ exports[`Storyshots UI|Settings/AboutScreen failed to fetch new version 1`] = ` class="emotion-22" > @@ -554,7 +512,7 @@ exports[`Storyshots UI|Settings/AboutScreen failed to fetch new version 1`] = ` @@ -565,7 +523,7 @@ exports[`Storyshots UI|Settings/AboutScreen failed to fetch new version 1`] = `