Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addon-knobs: Fix null knob values in select #9416

Merged
merged 1 commit into from Jan 13, 2020
Merged

Addon-knobs: Fix null knob values in select #9416

merged 1 commit into from Jan 13, 2020

Conversation

ndelangen
Copy link
Member

Issue: #9405

What I did

ADD a story to test
FIX the bug by adding a === null check

@ndelangen ndelangen added bug addon: knobs patch:yes Bugfix & documentation PR that need to be picked to main branch labels Jan 13, 2020
@ndelangen ndelangen added this to the 5.3.x milestone Jan 13, 2020
@ndelangen ndelangen self-assigned this Jan 13, 2020
@vercel
Copy link

vercel bot commented Jan 13, 2020 •
edited

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/g5jdc0icx
✅ Preview: https://monorepo-git-fix-null-as-valid-value-knobs-select.storybook.now.sh

@shilman shilman changed the title FIX https://github.com/storybookjs/storybook/issues/9405 Addon-knobs: Fix null knob values in select Jan 13, 2020
shilman
shilman approved these changes Jan 13, 2020
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shilman shilman merged commit 98792f3 into next Jan 13, 2020
@shilman shilman deleted the fix/null-as-valid-value-knobs-select branch January 13, 2020 20:39
shilman added a commit that referenced this pull request Jan 13, 2020
@shilman
Addon-knobs: Fix null knob values in select (#9416)
42fa30b 
Addon-knobs: Fix null knob values in select
@shilman shilman mentioned this pull request Jan 14, 2020
Closed
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jan 16, 2020
This was referenced Feb 12, 2020
Closed
Closed
Closed
Closed
Closed
This was referenced Feb 24, 2020
Closed
Closed
Closed
@dependabot-preview dependabot-preview bot mentioned this pull request Feb 24, 2020
Closed
@Hypnosphi Hypnosphi mentioned this pull request Jan 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@alexandrebodin alexandrebodin Awaiting requested review from alexandrebodin

@alterx alterx Awaiting requested review from alterx

@leonrodenburg leonrodenburg Awaiting requested review from leonrodenburg

@theinterned theinterned Awaiting requested review from theinterned

@usulpro usulpro Awaiting requested review from usulpro

Assignees

@ndelangen ndelangen

Labels
addon: knobs bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
5.3.x
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ndelangen @shilman