Fix broken link to repo in empty knobs panel #9530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The link to repo in empty knobs panel couldn't be triggered. The problem was with missing `cancel={false}` prop, because `Link` component has a `cancel={true}` by default.
fireseasonnow
requested review from
alexandrebodin,
alterx,
leonrodenburg and
theinterned
as code owners
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/storybook/monorepo/rcdvpah0v |
ndelangen
approved these changes
Jan 21, 2020
ndelangen
added
addon: knobs
bug
patch:yes
shilman
added
the
patch:done
shilman
pushed a commit
that referenced
this pull request
Jan 21, 2020
Fix broken link to repo in empty knobs panel
This was referenced Feb 12, 2020
This was referenced Feb 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
The link to repo in empty knobs panel couldn't be triggered. The problem was with missing
cancel={false}prop, becauseLinkcomponent has acancel={true}by default.How to test