fix(webcomponents): make types play nicely with lit-element #9557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, returning html`<sometag>...</sometag>` from `storiesOf(...).add` would result in the following error: Type 'TemplateResult' is not assignable to type 'StoryFnHtmlReturnType'
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/storybook/monorepo/lnt7vsofn |
ndelangen
approved these changes
Jan 20, 2020
|
I think we need a eslint-ignore-next-line rule for: |
|
@ndelangen do you want me to amend the pull request and add this? |
|
I read: "would you please amend the PR", so I went ahead and did it. Thanks for the PR @urish! |
ndelangen
approved these changes
Jan 21, 2020
ndelangen
added
the
patch:yes
|
Even better :-) p.s. you can see it in action here: https://elements.wokwi.com/ |
shilman
added
the
patch:done
shilman
pushed a commit
that referenced
this pull request
Feb 2, 2020
fix(webcomponents): make types play nicely with lit-element
This was referenced Feb 24, 2020
Closed
This was referenced Feb 24, 2020
urish
added a commit
to wokwi/wokwi-elements
that referenced
this pull request
Mar 30, 2020
also remove patch-package, as the following PR was merged: storybookjs/storybook#9557
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Before this change, returning html
<sometag>...</sometag>fromstoriesOf(...).addwould result in the following error: Type 'TemplateResult' is not assignable to type 'StoryFnHtmlReturnType'