Fix @storybook/addon-storyshots not being able to read config from main.ts #9577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iiroj
requested review from
igor-dv,
ndelangen,
shilman and
thomasbertet
as code owners
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/storybook/monorepo/e1onvxh0w |
|
Thanks @iiroj. Unfortunately |
shilman
approved these changes
Feb 3, 2020
This was referenced Feb 24, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
@storybook/addon-storyshotscannot read the new declarative configuration introduced in 5.3 from a TS file, but only a JS file.What I did
This PR enables
main.tsas well asmain.jsin the same style as as thepreviewandconfigfiles are loaded.This fixes #9576
How to test
I'm new to contributing to storybook, and couldn't see any tests for this feature. I didn't add any either, but if you require I can also add tests.