Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIGRATE ember to new "import { hbs } from 'ember-cli-htmlbars'" #9633

Merged
merged 3 commits into from Jan 25, 2020

Conversation

ndelangen
Copy link
Member

Issue: storybookjs/ember-cli-storybook#20

What I did

  • I upgraded a few ember packages
  • Added some config to remove the deprecation warning about jQuery
  • MIGRATED to use the new package where hbs comes from

Thank for the pair programming session on this @gossi (all credit goes to him)

How to test

The example for ember should function

Can we get this into 5.3 at some point @shilman

@vercel
Copy link

vercel bot commented Jan 25, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

@ndelangen ndelangen merged commit 56647e8 into next Jan 25, 2020
@ndelangen ndelangen deleted the fix/ember-build branch January 25, 2020 13:53
@ndelangen
Copy link
Member Author

@shilman can we get this in a alpha release soon?

@shilman shilman added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Jan 25, 2020
@dbendaou
Copy link
Member

Thanks guys !! 🥳

@shilman
Copy link
Member

shilman commented Jan 27, 2020

@ndelangen @gossi great job fixing this! unfortunately my net connection sucks, i'll be moving to another hotel on thurs, but it's also possible that the entire island has a bad connection. will release it on a patch on saturday at latest.

@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Feb 2, 2020
shilman pushed a commit that referenced this pull request Feb 2, 2020
MIGRATE ember to new "import { hbs } from 'ember-cli-htmlbars'"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ember maintenance User-facing maintenance tasks patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants