Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge pull request #9652 from storybookjs/fix/9462-sass-loading #9652

Merged
merged 1 commit into from Jan 28, 2020
Merged

Merge pull request #9652 from storybookjs/fix/9462-sass-loading #9652

merged 1 commit into from Jan 28, 2020

Conversation

ndelangen
Copy link
Member

Issue: #9462

What I did

UPGRADE the mini-css-extract-plugin

@ndelangen ndelangen added bug dependencies:update patch:yes Bugfix & documentation PR that need to be picked to main branch cra Prioritize create-react-app compatibility labels Jan 27, 2020
@ndelangen ndelangen added this to the 5.3.x milestone Jan 27, 2020
@ndelangen ndelangen self-assigned this Jan 27, 2020
@vercel
Copy link

vercel bot commented Jan 27, 2020 •
edited

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click on the icon next to each commit.

@github-actions
Copy link
Contributor

Fails
🚫

Please choose only one of these labels: ["bug","dependencies:update"]

Generated by 🚫 dangerJS against d636d56

@shilman shilman changed the title FIX 9462 Deps: Upgrade min-css-extract-plugin to fix Sass loading Jan 28, 2020
@shilman shilman changed the title Deps: Upgrade min-css-extract-plugin to fix Sass loading Core: Upgrade min-css-extract-plugin to fix SASS loading Jan 28, 2020
@shilman shilman changed the title Core: Upgrade min-css-extract-plugin to fix SASS loading Merge pull request #9652 from storybookjs/fix/9462-sass-loading Jan 28, 2020
@shilman shilman merged commit d30bad3 into next Jan 28, 2020
@shilman shilman deleted the fix/9462-sass-loading branch January 28, 2020 01:59
@shilman shilman mentioned this pull request Jan 30, 2020
Closed
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Feb 2, 2020
shilman added a commit that referenced this pull request Feb 2, 2020
@shilman
Merge pull request #9652 from storybookjs/fix/9462-sass-loading
2737f70 
Core: Upgrade `min-css-extract-plugin` to fix SASS loading
@shilman shilman mentioned this pull request Feb 7, 2020
Closed
This was referenced Feb 24, 2020
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Feb 24, 2020
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman Awaiting requested review from shilman

@thomasbertet thomasbertet Awaiting requested review from thomasbertet

Assignees

@ndelangen ndelangen

Labels
bug cra Prioritize create-react-app compatibility patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
5.3.x
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ndelangen @shilman