Fix default value for web components prop table docs #9655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As `custom-elements.json` format changed we have to support `default` to get the default value. This change still keeps compatibility with `defaultValue`.
ndelangen
approved these changes
Jan 30, 2020
shilman
added
patch:yes
shilman
pushed a commit
that referenced
this pull request
Feb 2, 2020
Fix default value for web components prop table docs
This was referenced Feb 24, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #9642
What I did
As
custom-elements.jsonformat changed we have to supportdefaultto get the default value for the prop table.This change still keeps compatibility with
defaultValue.For more information you can see the issue #9642 .