Svelte: Fix Svelte 3 slots for decorators #9724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilman
changed the title
shilman
added
the
patch:yes
shilman
approved these changes
Feb 4, 2020
|
Thanks @shilman for approving my PR. Though, I am a little concerned about the jest snapshot test that should have fail. |
|
@tonai I approved the changes in chromatic |
shilman
added
the
patch:done
shilman
added a commit
that referenced
this pull request
Feb 4, 2020
Svelte: Fix Svelte 3 slots for decorators
This was referenced Feb 24, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #8384
Fix centered addon decorator for Svelte 3.
Also fix other addons that uses decorators for Svelte 3.
What I did
I implemented the workaround from here sveltejs/svelte#2588 (comment) (with some adaptations and corrections).
How to test
svelte-kitchen-sinkI got a problem with the Jest snapshots because the test in this file should fail without the fix.
It is easily visible when testing manually with the
svelte-kitchen-sinkexample app.