Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] When logging certain objects, the browser crashes #238

Closed
hansottowirtz opened this issue Dec 31, 2022 · 1 comment · Fixed by #239
Closed

[Bug] When logging certain objects, the browser crashes #238

hansottowirtz opened this issue Dec 31, 2022 · 1 comment · Fixed by #239
Labels
bug Something isn't working prerelease released

Comments

@hansottowirtz
Copy link
Contributor

hansottowirtz commented Dec 31, 2022

Describe the bug

In some cases, safeStringify can hang, leading to a page crash of Chromium. I think this is because the circular dependencies aren't properly handled and lead to a crash.

When stringifying an array containing a React error, it seems to crash. See repro below.

The circular dependency removing code seems to have been added in #157.

Steps to reproduce the behavior

  1. Clone 'https://github.com/bubblydoo/react-done-tracker'
  2. Remove the resolutions field in package.json
  3. Run yarn
  4. Run yarn test-debug src/stories/Image.stories.tsx
  5. The Chrome instance will crash when running the InteractionTestError test.

Expected behavior

It shouldn't crash and log a useful error message.

Screenshots and/or logs

Screenshot 2022-12-31 at 16 44 20

@github-actions
Copy link

github-actions bot commented Apr 3, 2023

🚀 Issue was released in v0.10.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working prerelease released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant