Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip or Exclude not working on play-tests #424

Open
AmirTugi opened this issue Jan 17, 2024 · 2 comments
Open

Skip or Exclude not working on play-tests #424

AmirTugi opened this issue Jan 17, 2024 · 2 comments

Comments

@AmirTugi
Copy link

AmirTugi commented Jan 17, 2024

Describe the bug
I've added the skip tag (also tried with the exclude tag) to skip currently failing a11y tests, and I still see that some (or maybe all) the play-tests are running, regardless of the "skip" tag I added to them.

I also noticed that this is happening only to play tests where the play is async.

I noticed that the smoke-tests are skipped and that works fine. It's just the play-test.

Expected behavior
The play-test should also be skipped.

Screenshots

image image image

System

Storybook Environment Info:

System:
OS: macOS 14.2.1
CPU: (12) x64 Apple M2 Max
Shell: 5.9 - /bin/zsh
Binaries:
Node: 20.10.0 - ~/.volta/tools/image/node/20.10.0/bin/node
Yarn: 1.22.19 - ~/.volta/tools/image/yarn/1.22.19/bin/yarn <----- active
npm: 10.2.3 - ~/.volta/tools/image/node/20.10.0/bin/npm
Browsers:
Chrome: 120.0.6099.234
Safari: 17.2.1

@AmirTugi AmirTugi changed the title Skip or Exclude not working on play-tests Skip or Exclude not working on async play-tests Jan 17, 2024
@AmirTugi
Copy link
Author

AmirTugi commented Jan 24, 2024

I managed to find a workaround for now, and to add tags: ['a11y-skip'] directly to the story, and not in the component meta.
Seems like I was wrong about the async aspect.
It seems like that when tags is in the component-level - it works only for smoke-tests, and when it's for a specific story - it's also for its play-test.

I still think this is an issue, and at least should be documented.

@AmirTugi AmirTugi changed the title Skip or Exclude not working on async play-tests Skip or Exclude not working on play-tests Jan 24, 2024
@renatewr
Copy link

renatewr commented Apr 4, 2024

We had the exact same issue, and have spent hours debugging.

The link to the erroring story/play test is working, but running test-storybook the "play test" logged out "message: null".

I can confirm that this workaround works - the story is then excluded.

However, I would like to figure out why it fails, but I cannot get any debug information, since the built story is working fine.
I suspect that the reason is that the story is actually loading a video player.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants