Security: Upgrade json5 dependency #20526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I hadn't noticed, but this targets the @shilman can you take this one? |
|
Hi, I noticed this PR hasn't been merged into |
|
@dennisvdwaag Yes, have released on an alpha and plan to do the full release this week |
|
@shilman Awesome, thanks for the speedy reply! |
|
@dennisvdwaag NP, thanks for your patience! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
What I did
Since there is a vulnerability (Prototype Pollution in JSON5 via Parse) in the
json5package for version<2.2.2, it is upgraded to^2.2.3.The security info can be found on GHSA-9c47-m6qq-7p4h
How to test
If your answer is yes to any of these, please make sure to include it in your PR.