CLI: fix support for env vars when running dev
/build
commands
#21152
+29
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21055
What I did
Fixed the target of the
getEnvConfig
call to reference an object that is subsequently passed to thedev
/build
helper functions.getEnvConfig
was previously updatingprogram
, which appears to be a carryover from the old implementation where options were actually being read fromprogram
. Since options are now being passed to thedev
/build
functions directly, any options derived from environment variables were effectively being ignored.(It also appears the logic to convert a string port value to a number was also effectively going unused, but as far as I can tell, it didn't matter.)
How to test
yarn storybook
with env vars. e.g.,CI=true yarn storybook
should not open a browser or prompt if there is a port conflictSBCONFIG_PORT=8888 yarn storybook
should start storybook on port 8888Not sure a good way to add a test for this behavior?
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:merged
orci:daily
GH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]