Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Fix storySort parsing in preview.js with default export #21353

Merged
merged 1 commit into from Mar 2, 2023
Merged

Core: Fix storySort parsing in preview.js with default export #21353

merged 1 commit into from Mar 2, 2023

Conversation

shilman
Copy link
Member

@shilman shilman commented Mar 2, 2023 •
edited

Closes #21322

What I did

  • Handle parsing preview.js/preview.ts with default exports`

Self-merging @tmeasday

How to test

  • See attached unit tests
  • Try a sandbox with a default export & user-defined storySort

@shilman shilman merged commit 990c9a6 into next Mar 2, 2023
@shilman shilman deleted the shilman/21322-previewjs-default-storysort branch March 2, 2023 17:04
@shilman shilman mentioned this pull request Mar 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug core story index
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Storybook v7 (Beta 54) does not respect parameters.options.storySort
1 participant
@shilman