Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade react-docgen-typescript-plugin for TS4.8 #21380

Merged
merged 1 commit into from Mar 3, 2023

Conversation

shilman
Copy link
Member

@shilman shilman commented Mar 3, 2023

Closes #19055

What I did

Fixed #21145 in our fork of react-docgen-typescript-plugin. If this works will try to get it merged back into the trunk.

Self-merging @ndelangen

How to test

  • CI passes
  • Update the cra-ts sandbox Button with:
export default function Button({
  primary = false,
  size = 'medium',
  backgroundColor,
  label,
  ...props
}: ButtonProps) {
  const mode = primary ? 'storybook-button--primary' : 'storybook-button--secondary';
  return (
    <button
      type="button"
      className={['storybook-button', `storybook-button--${size}`, mode].join(' ')}
      style={{ backgroundColor }}
      {...props}
    >
      {label}
    </button>
  );
};

@shilman shilman added dependencies ci:daily Run the CI jobs that normally run in the daily job. labels Mar 3, 2023
@shilman shilman merged commit 94c3984 into next Mar 3, 2023
@shilman shilman deleted the shilman/upgrade-react-docgen-typescript branch March 3, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:daily Run the CI jobs that normally run in the daily job. dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: docgen bug with export default function ... Deprecation warnings after upgrade to TS 4.8
1 participant