Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Warn the user when stories glob does not match any file #21392

Merged
merged 1 commit into from Mar 8, 2023

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Mar 3, 2023

Closes #21378

What I did

Added a warning when a glob does not match, details in the issue

image

How to test

  1. Run a sandbox for template, e.g. yarn task --task sandbox --start-from auto --template react-vite/default-ts
  2. Add a stories glob that does not match any file
  3. Run Storybook
  4. Get the log

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@yannbf yannbf force-pushed the feat/warn-on-unmatched-glob branch from afe0370 to d19fd24 Compare March 7, 2023 18:13
@yannbf yannbf merged commit 8c165cb into next Mar 8, 2023
56 checks passed
@yannbf yannbf deleted the feat/warn-on-unmatched-glob branch March 8, 2023 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks story index
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Notify users when stories globs didn't match any files on startup
3 participants