Story Index: Fix storySort parsing for parameters variable #21481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmeasday
reviewed
Mar 8, 2023
| @@ -76,15 +76,18 @@ const parseParameters = (params: t.Expression): t.Expression | undefined => { | |||
| unsupported('options', true); | |||
| } | |||
| } else { | |||
| unsupported('parameters', true); | |||
| console.log({ paramsObject }); | |||
There was a problem hiding this comment.
@shilman is this log intentional?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21455
What I did
Fixed handling of parameters defined as a variable in the default export & added test cases
I also changed the behavior to be a little less strict about other cases & assume that some other part of Storybook will catch issues with, say, invalid parameters
Self-merging @tmeasday
How to test