Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inline story style #21870

Merged
merged 2 commits into from Apr 25, 2023
Merged

Fix inline story style #21870

merged 2 commits into from Apr 25, 2023

Conversation

0916dhkim
Copy link
Contributor

Closes #21831

What I did

<InlineStory> component has a typo in its inline css where it selects ID for the story block. This PR fixes the typo.

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@yannbf
Copy link
Member

yannbf commented Apr 3, 2023

Hey @0916dhkim Thank you so much for your contribution! Great catch 🚀

@0916dhkim
Copy link
Contributor Author

@yannbf Happy to contribute! By the way, what would be the best way to find other Storybook issues that are first-time friendly?

I'm regularly organizing public mob programming sessions at TorontoJS community, and there are many developers who are interested in open-source contribution. In fact, this PR was created during one of those sessions 😄
https://www.meetup.com/torontojs/events/dctzbtyfcfbxb/

TorontoJS is a non-profit 100% volunteer-run community, so any advice or support is appreciated. Hope I can contribute more to Storybook!

@yannbf
Copy link
Member

yannbf commented Apr 21, 2023

@yannbf Happy to contribute! By the way, what would be the best way to find other Storybook issues that are first-time friendly?

I'm regularly organizing public mob programming sessions at TorontoJS community, and there are many developers who are interested in open-source contribution. In fact, this PR was created during one of those sessions 😄 meetup.com/torontojs/events/dctzbtyfcfbxb

TorontoJS is a non-profit 100% volunteer-run community, so any advice or support is appreciated. Hope I can contribute more to Storybook!

Ah that is amazing to know! @usrrname @winkerVSbecks you might even know @0916dhkim!
@vanessayuenn maybe you are interested in this collaboration for community contributions!

@usrrname
Copy link
Contributor

Yep @0916dhkim runs our mob-programming style JS Code Club, it's awesome!

@usrrname
Copy link
Contributor

screaming! two of my favourite things working together! haha

Copy link
Contributor

@JReinhold JReinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you so much! 🥳

@JReinhold JReinhold added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Apr 25, 2023
@JReinhold JReinhold merged commit e7817e8 into storybookjs:next Apr 25, 2023
54 checks passed
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label May 3, 2023
shilman pushed a commit that referenced this pull request May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
block: other bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
5 participants