Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: (CLI) Fix CLI sandbox command #21977

Merged
merged 1 commit into from Apr 12, 2023

Conversation

jonniebigodes
Copy link
Contributor

With this small pull request, the CLI's sandbox command is updated to feature the correct command usage when generating a sandbox.

@yannbf @kasperpeulen, when any of you can take a look and let me know of any feedback so that we can continue to work on this or merge it? Thanks in advance.

@jonniebigodes jonniebigodes added cli patch:yes Bugfix & documentation PR that need to be picked to main branch labels Apr 6, 2023
@jonniebigodes jonniebigodes self-assigned this Apr 6, 2023
Copy link
Contributor

@kasperpeulen kasperpeulen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonniebigodes
Copy link
Contributor Author

@kasperpeulen, thanks for taking the time to review and approve this pull request. Appreciate it. 🙏 Going to merge it.

@jonniebigodes jonniebigodes merged commit 9820891 into next Apr 12, 2023
68 of 69 checks passed
@jonniebigodes jonniebigodes deleted the fix_sandbox_command_instructions branch April 12, 2023 15:49
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Apr 15, 2023
shilman pushed a commit that referenced this pull request Apr 15, 2023
…ctions

Chore: (CLI) Fix CLI sandbox command
@shilman shilman added the bug label Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cli patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants