CLI: Catch errors thrown on sanity check of SB installs #22039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… use it in findInstallations method of NPMProxy to ignore errors returned by npm ls command
valentinpalkovic
added
the
patch:yes
yannbf
approved these changes
Apr 12, 2023
shilman
changed the title
shilman
approved these changes
Apr 12, 2023
shilman
added
the
patch:done
shilman
added a commit
that referenced
this pull request
Apr 12, 2023
…cted-error-thrown-1 CLI: Catch errors thrown on sanity check of SB installs
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21872
What I did
Add ignoreError flag to executeCommand method in JsPackageManager and use it in findInstallations method of NPMProxy to ignore errors returned by npm ls command
How to test
upgradecommand in a repro wherenpm ls --json --depth=99returns some errors, like unmeet peer-dep errorsChecklist
MIGRATION.MD
Maintainers
make sure to add the
ci:mergedorci:dailyGH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]