Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Add new tags to distinguish docs attachment #22120

Merged
merged 2 commits into from Apr 18, 2023

Conversation

tmeasday
Copy link
Member

Part of fix for #21798

What I did

  • Add two tags attached-mdx and unattached-mdx so we can tell if a MDX file it attached without rendering it
  • Ensure the attached CSF file is always first so we know what it is.

Now all docs files have the docs tag and one of:

  • stories-mdx
  • autodocs
  • attached-mdx
  • unattached-mdx.

How to test

See tests, check sandbox indexes.

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@tmeasday tmeasday requested a review from shilman April 17, 2023 04:39
@shilman shilman changed the title Core: Add new tags (un)attached-mdx to distinguish attachment Core: Add new tags un/attached-mdx to distinguish attachment Apr 18, 2023
@shilman shilman changed the title Core: Add new tags un/attached-mdx to distinguish attachment Core: Add new tags to distinguish docs attachment Apr 18, 2023
@shilman shilman merged commit fdadeb7 into next Apr 18, 2023
69 checks passed
@shilman shilman deleted the tom/21798-add-attached-mdx-to-index branch April 18, 2023 09:56
@tmeasday tmeasday added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Apr 19, 2023
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Apr 24, 2023
shilman added a commit that referenced this pull request Apr 24, 2023
…-to-index

Core: Add new tags to distinguish docs attachment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug core patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants