Bug: simplify the export type of addon actions decorator so it doesn't get generated incorrectly #22175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… generated incorrectly
ndelangen
added
bug
addon: actions
patch:yes
|
👋 @jattasNI @shannonmoeller @stof care to review? 🙏 |
stof
approved these changes
Apr 20, 2023
shilman
added
the
patch:done
shilman
pushed a commit
that referenced
this pull request
Apr 24, 2023
Bug: simplify the export type of addon actions decorator so it doesn't get generated incorrectly
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21820
What I did
Looks like tsup is generating the typings wrong for this file, referencing a path that only exists in the monorepo.
I traced the output code, it's trying to reference, and it's just a function type of any to any, pretty useless.
So trying to fix the actual issue inside tsup can wait; I fixed the issue by making the type better by referencing @storybook/types instead.
I verified the output typings file is correct that way.