Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: Fix lit sandboxes #22201

Merged
merged 1 commit into from Apr 21, 2023
Merged

Build: Fix lit sandboxes #22201

merged 1 commit into from Apr 21, 2023

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Apr 21, 2023

Closes #

What I did

Recently Vite changed their lit template which removed the usage of a vite.config.js file, therefore the sandboxes were generating a webpack Storybook.

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@yannbf @valentinpalkovic
Fix lit sandboxes
68ad74f 
Co-authored-by: Valentin Palkovic <valentin@chromatic.com>
@yannbf yannbf added patch:yes Bugfix & documentation PR that need to be picked to main branch build Internal-facing build tooling & test updates labels Apr 21, 2023
@yannbf yannbf merged commit 6c20575 into next Apr 21, 2023
44 of 48 checks passed
@yannbf yannbf deleted the feat/fix-lit-vite-sandboxes branch April 21, 2023 14:05
@kuriacka kuriacka mentioned this pull request Apr 21, 2023
Closed
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Apr 24, 2023
shilman pushed a commit that referenced this pull request Apr 24, 2023
@yannbf @shilman
Merge pull request #22201 from storybookjs/feat/fix-lit-vite-sandboxes
94afe49 
Build: Fix lit sandboxes
@dannyhw dannyhw mentioned this pull request Feb 5, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valentinpalkovic valentinpalkovic valentinpalkovic approved these changes

Assignees

@yannbf yannbf

@valentinpalkovic valentinpalkovic

Labels
build Internal-facing build tooling & test updates patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yannbf @valentinpalkovic @shilman