Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Add web-components webpack5 to missing-babelrc automigration #22202

Merged
merged 2 commits into from Apr 26, 2023

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Apr 21, 2023

Closes #

What I did

Adds babelrc to web components projects that do not use vite!

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

Co-authored-by: Valentin Palkovic <valentin@chromatic.com>
@yannbf yannbf added bug cli patch:yes Bugfix & documentation PR that need to be picked to main branch labels Apr 21, 2023
@valentinpalkovic valentinpalkovic merged commit 5930b8a into next Apr 26, 2023
57 checks passed
@valentinpalkovic valentinpalkovic deleted the fix/babelrc-web-components-webpack branch April 26, 2023 09:42
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label May 3, 2023
shilman pushed a commit that referenced this pull request May 3, 2023
…-webpack

CLI: Add web-components webpack5 to missing-babelrc automigration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cli patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants