Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Rename manager UI mjs to js #22247

Merged
merged 6 commits into from Apr 25, 2023
Merged

Core: Rename manager UI mjs to js #22247

merged 6 commits into from Apr 25, 2023

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Apr 25, 2023 •
edited by shilman

Closes #22244

Experiment with changing the extension for prebundled code (preview and manager)

@ndelangen ndelangen self-assigned this Apr 25, 2023
@ndelangen ndelangen added the build Internal-facing build tooling & test updates label Apr 25, 2023
@ndelangen ndelangen requested a review from shilman April 25, 2023 12:12
@ndelangen ndelangen marked this pull request as ready for review April 25, 2023 14:23
@shilman shilman changed the title Make changes for the 2 packages that serve as prebundled, so their output is using the .js extension again Rename manager UI mjs to js Apr 25, 2023
shilman
shilman approved these changes Apr 25, 2023
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! Nice one @ndelangen

@shilman shilman changed the title Rename manager UI mjs to js Core: Rename manager UI mjs to js Apr 25, 2023
@shilman shilman merged commit 46e914d into next Apr 25, 2023
63 checks passed
@shilman shilman deleted the norbert/bundle-manager-to-js branch April 25, 2023 16:01
@shilman shilman added maintenance User-facing maintenance tasks and removed build Internal-facing build tooling & test updates labels Apr 25, 2023
@shilman shilman mentioned this pull request Apr 25, 2023
Closed
@shilman shilman added patch:yes Bugfix & documentation PR that need to be picked to main branch patch:done Patch/release PRs already cherry-picked to main/release branch labels May 3, 2023
shilman added a commit that referenced this pull request May 3, 2023
@shilman
Merge pull request #22247 from storybookjs/norbert/bundle-manager-to-js
8d637e1 
Core: Rename manager UI mjs to js
@hailwood hailwood mentioned this pull request May 10, 2023
Closed
@dannyhw dannyhw mentioned this pull request Feb 5, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

Assignees

@ndelangen ndelangen

Labels
maintenance User-facing maintenance tasks patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename manager UI mjs to js
2 participants
@ndelangen @shilman