Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Angular Unit tests #22355

Merged
merged 1 commit into from May 3, 2023
Merged

Conversation

valentinpalkovic
Copy link
Contributor

Closes N/A

What I did

Enabled Angular Tests

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@valentinpalkovic valentinpalkovic self-assigned this May 2, 2023
@valentinpalkovic valentinpalkovic added the maintenance User-facing maintenance tasks label May 2, 2023
@socket-security
Copy link

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script confusion ✅ 0 issues
Bin script shell injection ✅ 0 issues
Shell access ✅ 0 issues
Uses eval ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
GitHub dependency ✅ 0 issues
New author ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

➕ Added Package Capability Access +/- Transitive Count Publisher
jest-specific-snapshot@8.0.0 None +0 igor-dv

🚮 Removed packages: jest@28.1.3, jest-preset-angular@12.2.6

@valentinpalkovic valentinpalkovic force-pushed the valentin/enabled-angular-tests-1 branch 3 times, most recently from add8987 to 1216f9c Compare May 3, 2023 06:51
@valentinpalkovic valentinpalkovic force-pushed the valentin/enabled-angular-tests-1 branch from 1216f9c to 2a35b7c Compare May 3, 2023 08:49
@valentinpalkovic valentinpalkovic merged commit a3d722f into next May 3, 2023
54 of 56 checks passed
@valentinpalkovic valentinpalkovic deleted the valentin/enabled-angular-tests-1 branch May 3, 2023 09:31
@shilman
Copy link
Member

shilman commented May 3, 2023

@valentinpalkovic does this need to be patched?

@valentinpalkovic
Copy link
Contributor Author

no

@shilman shilman added patch:yes Bugfix & documentation PR that need to be picked to main branch patch:done Patch/release PRs already cherry-picked to main/release branch labels May 22, 2023
shilman pushed a commit that referenced this pull request May 22, 2023
@shilman shilman mentioned this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants