Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Error message for Angular.json file not found #22377

Merged
merged 3 commits into from May 8, 2023
Merged

Improve Error message for Angular.json file not found #22377

merged 3 commits into from May 8, 2023

Conversation

valentinpalkovic
Copy link
Contributor

@valentinpalkovic valentinpalkovic commented May 3, 2023 •
edited

Closes #22351

What I did

Improved error message and updated faq

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@valentinpalkovic valentinpalkovic self-assigned this May 3, 2023
@valentinpalkovic valentinpalkovic added the maintenance User-facing maintenance tasks label May 3, 2023
@valentinpalkovic valentinpalkovic force-pushed the valentin/improve-error-message-for-angular-json branch from 291446a to 250d5b9 Compare May 8, 2023 08:02
yannbf
yannbf reviewed May 8, 2023
View reviewed changes
docs/faq.md Show resolved Hide resolved
yannbf
yannbf reviewed May 8, 2023
View reviewed changes
docs/faq.md Outdated Show resolved Hide resolved
valentinpalkovic and others added 2 commits May 8, 2023 11:31
@valentinpalkovic @yannbf
Update docs/faq.md
b0b9ec1 
Co-authored-by: Yann Braga <yannbf@gmail.com>
@valentinpalkovic @yannbf
Update code/lib/cli/src/generators/ANGULAR/helpers.ts
351f105 
Co-authored-by: Yann Braga <yannbf@gmail.com>
@yannbf yannbf added cli patch:yes Bugfix & documentation PR that need to be picked to main branch labels May 8, 2023
yannbf
yannbf approved these changes May 8, 2023
View reviewed changes
Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome <3

@yannbf yannbf merged commit d1a4170 into next May 8, 2023
65 of 68 checks passed
@yannbf yannbf deleted the valentin/improve-error-message-for-angular-json branch May 8, 2023 14:44
@shilman shilman mentioned this pull request May 9, 2023
Closed
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label May 9, 2023
shilman pushed a commit that referenced this pull request May 9, 2023
@yannbf @shilman
Merge pull request #22377 from storybookjs/valentin/improve-error-mes…
82e0759 
…sage-for-angular-json

Improve Error message for Angular.json file not found
@shilman shilman mentioned this pull request May 9, 2023
Merged
@dannyhw dannyhw mentioned this pull request Feb 5, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yannbf yannbf yannbf approved these changes

Assignees

@valentinpalkovic valentinpalkovic

Labels
cli maintenance User-facing maintenance tasks patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

storybook init: No angular.json file found
3 participants
@valentinpalkovic @yannbf @shilman