Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update typescript version to include both 4.0.0 and 5.0.0 in package.json #22391

Merged
merged 2 commits into from May 4, 2023
Merged

Update typescript version to include both 4.0.0 and 5.0.0 in package.json #22391

merged 2 commits into from May 4, 2023

Conversation

valentinpalkovic
Copy link
Contributor

Closes N/A

What I did

Allow Typescript 5 to be used in Angular projects.

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@valentinpalkovic valentinpalkovic added the maintenance User-facing maintenance tasks label May 4, 2023
@valentinpalkovic valentinpalkovic self-assigned this May 4, 2023
@valentinpalkovic valentinpalkovic added the patch:yes Bugfix & documentation PR that need to be picked to main branch label May 4, 2023
yannbf
yannbf approved these changes May 4, 2023
View reviewed changes
Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@valentinpalkovic valentinpalkovic merged commit c53db1f into next May 4, 2023
61 of 62 checks passed
@valentinpalkovic valentinpalkovic deleted the valentin/adjust-typescript-range-in-angular branch May 4, 2023 09:43
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label May 5, 2023
shilman pushed a commit that referenced this pull request May 5, 2023
@valentinpalkovic @shilman
Merge pull request #22391 from storybookjs/valentin/adjust-typescript…
8dd709d 
…-range-in-angular

Update typescript version to include both 4.0.0 and 5.0.0 in package.json
@dannyhw dannyhw mentioned this pull request Feb 5, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yannbf yannbf yannbf approved these changes

@ndelangen ndelangen Awaiting requested review from ndelangen

Assignees

@valentinpalkovic valentinpalkovic

Labels
maintenance User-facing maintenance tasks patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@valentinpalkovic @yannbf @shilman