Fix: remove the alias for global
#22393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndelangen
added
bug
patch:yes
ndelangen
changed the title
ndelangen
changed the title
global
|
@ndelangen can you explain why this is needed? |
|
It used to be so that we depended on a package called global. This package has no typings. Or more likely I kept it around for backwards compatibility? I think it's safe to remove now, especially if it's causing issues. |
tmeasday
approved these changes
May 5, 2023
shilman
added
the
patch:done
shilman
pushed a commit
that referenced
this pull request
May 22, 2023
Fix: remove the alias for `global`
Merged
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21242
What I did
Remove the alias for
globalfor webpack