Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Fix server init #22443

Merged
merged 9 commits into from May 9, 2023
Merged

CLI: Fix server init #22443

merged 9 commits into from May 9, 2023

Conversation

shilman
Copy link
Member

@shilman shilman commented May 8, 2023

Telescopes on #22375

What I did

Remove the copyTemplate code from CLI init for @storybook/server. It is already handled by the baseGenerator.

Note that #20627 is still a problem and this doesn't solve that.

How to test

mkdir test-project
cd test-project
yarn init -y
/path/to/cli/bin/index.js init -t server

Then verify that the *.stories.json files are successfully copied over into test-project.

@shilman shilman added bug cli patch:yes Bugfix & documentation PR that need to be picked to main branch server labels May 8, 2023
@shilman shilman mentioned this pull request May 8, 2023
3 tasks
shilman and others added 5 commits May 9, 2023 10:55
Server: Add json indexer to preset

Co-authored-by: Donnie Flood <donnie@floodfx.com>
…okjs/storybook into shilman/20627-fix-server-indexer
@shilman shilman merged commit 51f1877 into norbert/fix-22348 May 9, 2023
55 of 56 checks passed
@shilman shilman deleted the shilman/fix-cli-server-init branch May 9, 2023 07:52
@shilman shilman mentioned this pull request May 9, 2023
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cli patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants