Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: Throw errors instead of rejecting promises #22515

Merged
merged 1 commit into from May 11, 2023
Merged

CLI: Throw errors instead of rejecting promises #22515

merged 1 commit into from May 11, 2023

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented May 11, 2023

Closes #

What I did

We had breakages because error was undefined coming from Promise rejections. These are now turned into proper errors!

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@yannbf yannbf added bug cli patch:yes Bugfix & documentation PR that need to be picked to main branch labels May 11, 2023
@yannbf yannbf merged commit c56efde into next May 11, 2023
73 of 74 checks passed
@yannbf yannbf deleted the fix/fix-error-throwing branch May 11, 2023 17:45
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label May 12, 2023
shilman pushed a commit that referenced this pull request May 12, 2023
@yannbf @shilman
Merge pull request #22515 from storybookjs/fix/fix-error-throwing
918eba9 
CLI: Throw errors instead of rejecting promises
@shilman shilman mentioned this pull request May 12, 2023
Merged
@dannyhw dannyhw mentioned this pull request Feb 5, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valentinpalkovic valentinpalkovic valentinpalkovic approved these changes

@shilman shilman Awaiting requested review from shilman

Assignees
No one assigned
Labels
bug cli patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yannbf @valentinpalkovic @shilman