Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: set correct ref on sandboxes Github action #22625

Merged
merged 1 commit into from May 18, 2023
Merged

Build: set correct ref on sandboxes Github action #22625

merged 1 commit into from May 18, 2023

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented May 18, 2023

Closes #

What I did

Silly thing I forgot to revert from #22620

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@yannbf yannbf added patch:yes Bugfix & documentation PR that need to be picked to main branch build Internal-facing build tooling & test updates labels May 18, 2023
@yannbf
Copy link
Member Author

yannbf commented May 18, 2023

self merging cc @ndelangen

@yannbf yannbf merged commit 4b9dd0a into next May 18, 2023
45 of 49 checks passed
@yannbf yannbf deleted the fix/revert-sandboxes-ref branch May 18, 2023 16:54
shilman pushed a commit that referenced this pull request May 22, 2023
@yannbf @shilman
Merge pull request #22625 from storybookjs/fix/revert-sandboxes-ref
24e8439 
Build: set correct ref on sandboxes Github action
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label May 22, 2023
@shilman shilman mentioned this pull request May 22, 2023
Merged
@dannyhw dannyhw mentioned this pull request Feb 5, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
build Internal-facing build tooling & test updates patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yannbf @shilman