Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: Account for windows paths when copying templates #22644

Merged
merged 1 commit into from May 19, 2023
Merged

CLI: Account for windows paths when copying templates #22644

merged 1 commit into from May 19, 2023

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented May 19, 2023 •
edited

Closes #

What I did

stopped using / to account for windows paths!

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@yannbf yannbf added bug cli patch:yes Bugfix & documentation PR that need to be picked to main branch labels May 19, 2023
@shilman shilman changed the title CLI: account for windows paths when copying templates CLI: Account for windows paths when copying templates May 19, 2023
@shilman shilman merged commit 91af087 into next May 19, 2023
73 of 74 checks passed
@shilman shilman deleted the fix/windows-paths branch May 19, 2023 17:11
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label May 22, 2023
shilman added a commit that referenced this pull request May 22, 2023
@shilman
Merge pull request #22644 from storybookjs/fix/windows-paths
edc0e78 
CLI: Account for windows paths when copying templates
@shilman shilman mentioned this pull request May 22, 2023
Merged
@dannyhw dannyhw mentioned this pull request Feb 5, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

Assignees
No one assigned
Labels
bug cli patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yannbf @shilman