Vue3: Revert v7 breaking change, restore reactive v6-compat API #22692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasperpeulen
force-pushed
the
kasper/main-patch-back-rollback
branch
3 times, most recently
from
9d5eed2
to
9cee100
Compare
5 tasks
…compatible Vue3: Rollback v7 breaking change and keep reactive v6-compatible API
Vue3: Fix reactive args updates in decorators
kasperpeulen
force-pushed
the
kasper/main-patch-back-rollback
branch
from
de856ce
to
a5bef95
Compare
kasperpeulen
added
ci:daily
shilman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Patch back #22229 to main.
Somehow this fixes a lot of chromatic test cases on main by itself, which surprised me.
I think the ReactiveDecorator tests may be fixed by this line, as that story doesn't override the default storybook render function, and will use this render function instead:
The chromatic failure is fixed by:
#22717
Which we need to first merge to next, and then cherry pick here as well.