Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Improve of={...} DocBlock error in story index #22782

Merged
merged 1 commit into from Jun 8, 2023
Merged

Core: Improve of={...} DocBlock error in story index #22782

merged 1 commit into from Jun 8, 2023

Conversation

shilman
Copy link
Member

@shilman shilman commented May 25, 2023

Closes #22619

What I did

Better error message

How to test

N/A

@shilman shilman added maintenance User-facing maintenance tasks patch:yes Bugfix & documentation PR that need to be picked to main branch story index labels May 25, 2023
jonniebigodes
jonniebigodes approved these changes May 29, 2023
View reviewed changes
Copy link
Contributor

@jonniebigodes jonniebigodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting together this pull request and improve the messaging around. Appreciate it 🙏 ! Looks good on my end. Feel free to merge it when able.

@shilman shilman merged commit ec24911 into next Jun 8, 2023
63 of 66 checks passed
@shilman shilman deleted the shilman/22619-improve-mdx-of-error branch June 8, 2023 01:02
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jun 8, 2023
shilman added a commit that referenced this pull request Jun 8, 2023
@shilman
Merge pull request #22782 from storybookjs/shilman/22619-improve-mdx-…
d9edefd 
…of-error

Core: Improve MDX of error in story index
This was referenced Jun 8, 2023
Merged
Closed
Closed
@github-actions github-actions bot mentioned this pull request Jun 8, 2023
Merged
@JReinhold JReinhold changed the title Core: Improve MDX of error in story index Core: Improve of={...} DocBlock error in story index Jun 9, 2023
@shilman shilman removed the patch:done Patch/release PRs already cherry-picked to main/release branch label Jun 14, 2023
@github-actions github-actions bot mentioned this pull request Jun 14, 2023
Merged
69 tasks
@JReinhold JReinhold added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jun 15, 2023
@dannyhw dannyhw mentioned this pull request Feb 5, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonniebigodes jonniebigodes jonniebigodes approved these changes

Assignees

@shilman shilman

Labels
maintenance User-facing maintenance tasks patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch story index
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: "Could not find CSF file at path" error with Vite builder
3 participants
@shilman @jonniebigodes @JReinhold