Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: Fix Nextjs E2E tests #22816

Merged
merged 1 commit into from May 26, 2023
Merged

Build: Fix Nextjs E2E tests #22816

merged 1 commit into from May 26, 2023

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented May 26, 2023

Closes #

What I did

We forgot to patch back one E2E test fix, which is now added!

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@yannbf yannbf added build Internal-facing build tooling & test updates ci:daily Run the CI jobs that normally run in the daily job. labels May 26, 2023
@kasperpeulen kasperpeulen self-requested a review May 26, 2023 13:11
kasperpeulen
kasperpeulen approved these changes May 26, 2023
View reviewed changes
Copy link
Contributor

@kasperpeulen kasperpeulen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shilman shilman merged commit 2381a05 into main May 26, 2023
102 checks passed
@shilman shilman deleted the fix/patch-e2e-fix branch May 26, 2023 14:31
@shilman shilman mentioned this pull request May 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kasperpeulen kasperpeulen kasperpeulen approved these changes

Assignees
No one assigned
Labels
build Internal-facing build tooling & test updates ci:daily Run the CI jobs that normally run in the daily job.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yannbf @kasperpeulen @shilman @valentinpalkovic