Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD a no-dll option to CLI to disable DllReferencePlugin, fix polyfills missing in manager #5238

Merged
merged 2 commits into from Jan 14, 2019

Conversation

ndelangen
Copy link
Member

Fixes: #5055

What I did

  • ADD a no-dll option to CLI to disable DllReferencePlugin
  • FIX polyfills missing in manager
  • DISABLE dll for official example
  • ENABLE dll for all other examples

How to test

run the examples

@ndelangen ndelangen added bug configuration babel / webpack patch:yes Bugfix & documentation PR that need to be picked to main branch core labels Jan 14, 2019
@ndelangen ndelangen self-assigned this Jan 14, 2019
@codecov
Copy link

codecov bot commented Jan 14, 2019

Codecov Report

Merging #5238 into next will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #5238      +/-   ##
==========================================
- Coverage   30.05%   30.05%   -0.01%     
==========================================
  Files         608      608              
  Lines        8827     8825       -2     
  Branches     1290     1275      -15     
==========================================
- Hits         2653     2652       -1     
  Misses       5441     5441              
+ Partials      733      732       -1
Impacted Files Coverage Δ
lib/core/src/server/cli/dev.js 0% <ø> (ø) ⬆️
lib/core/src/server/dev-server.js 0% <ø> (ø) ⬆️
lib/core/src/server/cli/prod.js 0% <ø> (ø) ⬆️
.../core/src/server/manager/manager-webpack.config.js 0% <0%> (ø) ⬆️
lib/core/src/server/manager/manager-preset.js 0% <0%> (ø) ⬆️
lib/core/src/client/preview/start.js 80% <0%> (+2.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ab583b...3822e58. Read the comment docs.

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFM! This is a nice improvement!

@shilman shilman merged commit 0b296e1 into next Jan 14, 2019
@shilman shilman deleted the fix/dll branch January 14, 2019 15:33
@tmeasday
Copy link
Member

FIX polyfills missing in manager

Is this relevant to the issues people have had with the async/await code @ndelangen? E.g. the issue Lionel mentioned as well as #5235?

@ndelangen
Copy link
Member Author

YES, should work now!

@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jan 17, 2019
shilman added a commit that referenced this pull request Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug configuration babel / webpack core patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants