update modal manager for rn 0.58 support #5581
Conversation
ndelangen
force-pushed
the
RWOverdijk-patch-1
branch
from
a2519d8
to
52aa858
Compare
|
@RWOverdijk rebased on next branch, should be picked into the master branch |
ndelangen
added
the
patch:yes
| @@ -26,7 +26,7 @@ | |||
| "prop-types": "^15.6.2", | |||
| "react-native-color-picker": "^0.4.0", | |||
| "react-native-modal-datetime-picker": "^5.1.0", | |||
There was a problem hiding this comment.
consider bumping react-native-modal-datetime-picker too, this will be required for the 0.59 upgrade. If that's too much outside of the scope of this PR I can take a stab at it later.
There was a problem hiding this comment.
@benoitdion Tomorrow morning 08:00 UTC +1,
We're going on a chaos programming session to fix up Storybook for RN.
@igor-dv and I will be there, and we've invited a few more.
Goal is to get the server part working well again.
Secondary goal would be to upgrade a lot to the latest version, possibly babel etc.
If you'd be interested in helping, you're welcome to join, give advice, possibly learn abit about what's going on in our codebase?
Join our discord and PM me if you want an invite to the Zoom meeting.
There was a problem hiding this comment.
I'd LOVE a comprehensive PR upgrading RN to the latest and greatest of all versions!
Please tell me how I can help you make that happen!
Codecov Report
@@ Coverage Diff @@
## next #5581 +/- ##
=====================================
Coverage 33.2% 33.2%
=====================================
Files 647 647
Lines 9315 9315
Branches 1325 1325
=====================================
Hits 3093 3093
Misses 5607 5607
Partials 615 615Continue to review full report at Codecov.
|
shilman
added
the
patch:done
update modal manager for rn 0.58 support
Issue:
What I did
Update the dependency.
How to test
I simply added a select and then updated to see if it still works. And it does. A major version bump was included in this somewhere, but I can't see any breaking changes. Regardless, this works.