Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use static versions.json file instead of hacking one in #5675

Merged
merged 1 commit into from Feb 20, 2019

Conversation

shilman
Copy link
Member

@shilman shilman commented Feb 20, 2019

Issue: #5667

What I did

Use static versions file

How to test

yarn docs:dev
open http://localhost:8000/versions.json

@shilman shilman added the maintenance User-facing maintenance tasks label Feb 20, 2019
@shilman shilman added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Feb 20, 2019
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@shilman shilman merged commit a49b6d0 into next Feb 20, 2019
@shilman shilman deleted the shilman/5667-deploy-versions-json branch February 20, 2019 07:00
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Feb 20, 2019
shilman added a commit that referenced this pull request Feb 20, 2019
…-json

Use static versions.json file instead of hacking one in
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants