Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UNIX socket support #5920

Closed
impcyber opened this issue Apr 23, 2020 · 3 comments
Closed

Add UNIX socket support #5920

impcyber opened this issue Apr 23, 2020 · 3 comments
Labels
issue: feature request Issue suggesting a new feature severity: low If the issue only affects a very niche base of users and an easily implemented workaround can solve

Comments

@impcyber
Copy link

Please describe your feature request:
It would be nice to add support for connecting to the server through a UNIX socket, while simultaneously managing multiple sites on the same server, for example via nginx.
Something like this:
https://github.com/strapi/strapi/blob/master/packages/strapi/lib/Strapi.js#L270

    const listenArgs = this.config.socket
      ? { path: this.config.socket }
      : { host: this.config.host, port: this.config.port };

    if (listenArgs.path) {
      fse.pathExists(this.config.socket, (err, exists) => {
        exists && fse.remove(this.config.socket);
      });
    }

    this.server.listen(listenArgs, err => onListen(err));

https://github.com/strapi/strapi/blob/master/packages/strapi/lib/Strapi.js#L88

socket: '',

https://github.com/strapi/strapi/blob/master/packages/strapi/lib/core/bootstrap.js#L288

strapi.config.socket = _.get(strapi.config.currentEnvironment, 'server.socket') || strapi.config.socket;
@lauriejim
Copy link
Contributor

Hello! Can you please open an RFC.
I suggest you structure your issue there and close this one.
Thank you.

@lauriejim lauriejim added severity: low If the issue only affects a very niche base of users and an easily implemented workaround can solve issue: feature request Issue suggesting a new feature labels Apr 28, 2020
@impcyber
Copy link
Author

@lauriejim No problem

@derrickmehaffy
Copy link
Member

added in: #7824

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: feature request Issue suggesting a new feature severity: low If the issue only affects a very niche base of users and an easily implemented workaround can solve
Projects
None yet
Development

No branches or pull requests

3 participants