Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/config/plugins.js doesn't merge into local plugins #6725

Closed
laurenskling opened this issue Jun 18, 2020 · 3 comments
Closed

/config/plugins.js doesn't merge into local plugins #6725

laurenskling opened this issue Jun 18, 2020 · 3 comments
Labels
good first issue Good for newcomers issue: feature request Issue suggesting a new feature

Comments

@laurenskling
Copy link
Contributor

laurenskling commented Jun 18, 2020 •
edited

Describe the bug
Whether or not it makes sense to override local plugin config/settings.js with the general /config/plugins.js, it doesn't work. When I offloaded my plugin to be an installed package, it does work and merges in the values I've set in /config/plugin.js

System

  • Node.js version: 12.16.0
  • NPM version:
  • Strapi version: 3.0.0
  • Database: Mongo
  • Operating system: Macos

Additional context
I'm developing a local plugin in the /plugins folder. I want it to have default settings, and I want to be able to set override values in the global /config folder
@alexandrebodin alexandrebodin added issue: feature request Issue suggesting a new feature good first issue Good for newcomers labels Jun 18, 2020
tudorilisoi added a commit to tudorilisoi/strapi that referenced this issue Jun 22, 2020
@tudorilisoi
fixes strapi#6725
cc2f69a 
Signed-off-by: Tudor Ilisoi <tudorilisoi@yahoo.com>
@rmonnier9
Copy link

Hi !
Shouldn't you use plugins.js rather than plugin.js ?

@laurenskling laurenskling changed the title /config/plugin.js doesn't merge into local plugins /config/plugins.js doesn't merge into local plugins Jul 1, 2020
@laurenskling
Copy link
Contributor Author

yes, it should be. That isn't the issue tho, I just wrote it wrong for this issue

gilfernandes pushed a commit to onepointconsulting/strapi that referenced this issue Aug 13, 2020
@tudorilisoi @onepointconsulting
fixes strapi#6725 (strapi#6769)
57528d3 
* fixes strapi#6725

Signed-off-by: Tudor Ilisoi <tudorilisoi@yahoo.com>

* fixed L41

Signed-off-by: Tudor Ilisoi <tudorilisoi@yahoo.com>
Signed-off-by: Gil Fernandes <gil.fernandes@onepointltd.com>
@laurenskling
Copy link
Contributor Author

Thanks @tudorilisoi :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers issue: feature request Issue suggesting a new feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexandrebodin @laurenskling @rmonnier9