Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSRV bump to rust 1.48 in version 0.1.54 #100

Closed
astraw opened this issue Mar 22, 2023 · 2 comments
Closed

MSRV bump to rust 1.48 in version 0.1.54 #100

astraw opened this issue Mar 22, 2023 · 2 comments

Comments

@astraw
Copy link
Member

astraw commented Mar 22, 2023

From @djc #91 (comment):

So chrono 0.4 is still the active release branch, and is currently still maintaining an MSRV of 1.38. We're working on 0.5 (which requires 1.48) but that's not very close to being done. Would it be a big ask to request that this project keeps its MSRV at 1.38 for a bit longer?

Oh, I wasn't considering that we would exceed chrono's MSRV with release 0.1.54 that we just made yesterday. I apologize that I missed that. By the appearance of this comment, I am guessing this is an actual problem? I am pleased with removing so much unsafe code on Windows with release 0.1.54, so I would like to balance the problem of increased MSRV with the benefit of less unsafe.

On one hand, we could make a 0.1.55 release which is identical to 0.1.53 except in version number. We don't need to yank 0.1.54 as there's no security problem with it. (It just increases the MSRV.)

Alternatively, where old rust is required, iana-time-zone could be pinned to version <=0.1.53 . This would be more burden on the maintainers of software that requires old rust.

I definitely think this issue merits some discussion, so I've opened the new issue on it. @Kijewski your input is also welcome here.

@djc
Copy link
Contributor

djc commented Mar 22, 2023

Hah, I made an issue in chrono as well with a bit more context, let's discuss there?

chronotope/chrono#995

@astraw
Copy link
Member Author

astraw commented Mar 22, 2023

Yes. Closing this here for now.

@astraw astraw closed this as completed Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants