fix: fix name validation regex to accept file names beginning with a period #1005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G-Rath
reviewed
Feb 21, 2024
src/node-to-fsa/__tests__/NodeFileSystemDirectoryHandle.test.ts
Outdated
Show resolved
Hide resolved
|
(don't worry about that CI failure - it'll get "resolved" when the commits are squashed as part of merging) |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 21, 2024
## [4.7.7](v4.7.6...v4.7.7) (2024-02-21) ### Bug Fixes * accept file names beginning with a period ([#1005](#1005)) ([3c18dae](3c18dae))
|
🎉 This PR is included in version 4.7.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I was using node-to-fsa and realized that files beginning with a period, as in hidden *nix files, throw
from
src/node-to-fsa/util.ts:assertName.I am assuming that this is not an intended behavior, if this is a correct assumption, please accept my pull request.
I modified the regex and added a regression test case.