Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support calling chmod on a directory #870

Merged
merged 4 commits into from
Nov 3, 2022

Conversation

williamstein
Copy link
Contributor

@williamstein williamstein commented Oct 26, 2022

The fix for this is similar to the others I just submitting, so here it is.

Resolves #558

src/__tests__/volume.test.ts Outdated Show resolved Hide resolved
@G-Rath G-Rath changed the title fix #558 -- chmodSync throws EISDIR for directories fix: support calling chmod on a directory Oct 29, 2022
@G-Rath G-Rath added the bug label Oct 29, 2022
@williamstein
Copy link
Contributor Author

I've restructured the tests.

@G-Rath G-Rath merged commit 7c5999c into streamich:master Nov 3, 2022
streamich pushed a commit that referenced this pull request Nov 3, 2022
## [3.4.10](v3.4.9...v3.4.10) (2022-11-03)

### Bug Fixes

* support calling `chmod` on a directory ([#870](#870)) ([7c5999c](7c5999c)), closes [#558](#558)
@streamich
Copy link
Owner

🎉 This PR is included in version 3.4.10 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chmodSync throws EISDIR for directories
3 participants