Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React and react-dom in peer dependencies #236

Open
d1buts opened this issue Jul 31, 2019 · 2 comments
Open

React and react-dom in peer dependencies #236

d1buts opened this issue Jul 31, 2019 · 2 comments

Comments

@d1buts
Copy link

d1buts commented Jul 31, 2019

Hi, first of all thank you for so good library.

I'm using nano-css in my project based on Vue.js and every time during install dependencies I get warnings, that react and react-dom are not installed.

Everything works fine, except of that moment.

Can You fix that? Thanks

@mindplay-dk
Copy link

Using it with preact myself - this library is also useful without any library and just plain DOM.

Looks like the component add-on and react-preset is where these dependencies come from. (the jsx add-on itself doesn't seem to depend on React.)

Probably the React-specific features should be moved to a sub-package, e.g. css-nano/react, so the react-dependency can be moved out of the main package?

That's a breaking change though.

@mindplay-dk
Copy link

Actually, all of the presets probably should be moved to separate sub-packages? Since, currently, you're bundling all of them no matter which one you use, right? Even if you don't use any of them...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants