Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMCD does not protect against non-Finite numeric values #45

Closed
littlespex opened this issue Nov 29, 2023 · 0 comments
Closed

CMCD does not protect against non-Finite numeric values #45

littlespex opened this issue Nov 29, 2023 · 0 comments
Assignees
@littlespex
Milestone
0.6.0

Comments

@littlespex
Copy link
Collaborator

littlespex commented Nov 29, 2023 •
edited

Describe the bug
CMCD does not protect against NaN and Infinity numeric values.

To Reproduce
Steps to reproduce the behavior:

  1. Call encodeCmcd{{mtp: NaN});

Expected behavior
Non-finite CMCD numeric values should be ignored

Platform (please complete the following information):

  • All

Additional context
See montevideo-tech/videojs-cmcd#40
@littlespex littlespex changed the title CMCD does not protect against NaN and Infinity numeric values CMCD does not protect against non-Finite numeric values Nov 29, 2023
littlespex added a commit that referenced this issue Nov 29, 2023
@littlespex
fix: ignore non-finite numeric values
7ae9c49 
see #45
@littlespex littlespex mentioned this issue Nov 29, 2023
Merged
2 tasks
littlespex added a commit that referenced this issue Nov 29, 2023
@littlespex
fix: ignore non-finite numeric values
897e5c5 
see #45

Signed-off-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com>
littlespex added a commit that referenced this issue Nov 29, 2023
@littlespex
fix: ignore non-finite numeric values (#46)
6cdbeef 
see #45

Signed-off-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com>
@littlespex littlespex added this to the 0.6.0 milestone Nov 29, 2023
@littlespex littlespex self-assigned this Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@littlespex littlespex

Labels
None yet
Projects
None yet
Milestone
0.6.0
Development

No branches or pull requests
1 participant
@littlespex