Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

appendCmcdQuery does not account for existing CMCD query params #48

Closed
littlespex opened this issue Nov 29, 2023 · 0 comments
Closed

appendCmcdQuery does not account for existing CMCD query params #48

littlespex opened this issue Nov 29, 2023 · 0 comments
Assignees
@littlespex
Milestone
0.6.0

Comments

@littlespex
Copy link
Collaborator

Describe the bug
When using appendCmcdQuery, if the URL already has a CMCD param a duplicate will be added.

To Reproduce
Steps to reproduce the behavior:

  1. Call appendCmcdQuery('https://test.com/?CMCD=bs%2Cot%3Dm%2Csf%3Dh', {mtp: 123})

Expected behavior
There resulting URL should only have one CMCD query parameter

Platform (please complete the following information):

  • All

Additional context
See montevideo-tech/videojs-cmcd#40
@littlespex littlespex added this to the 0.6.0 milestone Nov 29, 2023
littlespex added a commit that referenced this issue Nov 30, 2023
@littlespex
fix: replace CMCD query param when appending new data
48bb94c 
see: #48
Signed-off-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com>
@littlespex littlespex mentioned this issue Nov 30, 2023
Merged
littlespex added a commit that referenced this issue Nov 30, 2023
@littlespex
fix: replace CMCD query param when appending new data (#52)
8b1d025 
see: #48

Signed-off-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com>
@littlespex littlespex self-assigned this Nov 30, 2023
littlespex added a commit to qualabs/common-media-library that referenced this issue Apr 5, 2024
@littlespex
fix: replace CMCD query param when appending new data (streaming-vide…
ec64580 
…o-technology-alliance#52)

see: streaming-video-technology-alliance#48

Signed-off-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@littlespex littlespex

Labels
None yet
Projects
None yet
Milestone
0.6.0
Development

No branches or pull requests
1 participant
@littlespex