Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Zookeeper dashboard #66

Open
codelipenghui opened this issue Sep 10, 2021 · 1 comment
Open

Update Zookeeper dashboard #66

codelipenghui opened this issue Sep 10, 2021 · 1 comment

Comments

@codelipenghui
Copy link
Contributor

We have removed the AspectJ based metrics for ZooKeeper, we need to update the Zookeeper dashboard for Pulsar version which is greater than 2.8

@Bklyn
Copy link
Contributor

Bklyn commented Mar 23, 2022

There is now a dashboards.template/zookeeper-3.6.json.j2, but it fails to render due to the use of the following variables unknown to Jinja:

  • {{instance}}. Should this be $instance?
Traceback (most recent call last):
  File "/tmp/.local/bin/j2", line 8, in <module>
    sys.exit(main())
  File "/tmp/.local/lib/python3.8/site-packages/j2cli/cli.py", line 202, in main
    output = render_command(
  File "/tmp/.local/lib/python3.8/site-packages/j2cli/cli.py", line 186, in render_command
    result = renderer.render(args.template, context)
  File "/tmp/.local/lib/python3.8/site-packages/j2cli/cli.py", line 85, in render
    return self._env \
  File "/tmp/.local/lib/python3.8/site-packages/jinja2/environment.py", line 1291, in render
    self.environment.handle_exception()
  File "/tmp/.local/lib/python3.8/site-packages/jinja2/environment.py", line 925, in handle_exception
    raise rewrite_traceback_stack(source=source)
  File "/tmp/src/apache-pulsar-grafana-dashboard/dashboards.template/zookeeper-3.6.json.j2", line 140, in top-level template code
    "legendFormat": "{{instance}} znode_count",
jinja2.exceptions.UndefinedError: 'instance' is undefined
  • {{key}} as in:
Traceback (most recent call last):
  File "/tmp/.local/bin/j2", line 8, in <module>
    sys.exit(main())
  File "/tmp/.local/lib/python3.8/site-packages/j2cli/cli.py", line 202, in main
    output = render_command(
  File "/tmp/.local/lib/python3.8/site-packages/j2cli/cli.py", line 186, in render_command
    result = renderer.render(args.template, context)
  File "/tmp/.local/lib/python3.8/site-packages/j2cli/cli.py", line 85, in render
    return self._env \
  File "/tmp/.local/lib/python3.8/site-packages/jinja2/environment.py", line 1291, in render
    self.environment.handle_exception()
  File "/tmp/.local/lib/python3.8/site-packages/jinja2/environment.py", line 925, in handle_exception
    raise rewrite_traceback_stack(source=source)
  File "/tmp/src/apache-pulsar-grafana-dashboard/dashboards.template/zookeeper-3.6.json.j2", line 448, in top-level template code
    "legendFormat": "write_per_namespace:{{key}}",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants