Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up Jetpack Compose #5447

Closed
westnordost opened this issue Jan 17, 2024 · 1 comment
Closed

Set up Jetpack Compose #5447

westnordost opened this issue Jan 17, 2024 · 1 comment
Assignees
Labels
iOS necessary for iOS port

Comments

@westnordost
Copy link
Member

Other than adding the dependency, the (dark+light) theme, style, colors, fonts are defined in code in Jetpack Compose rather than in res/values/*.xml files.

So, as a start, the current theme etc should be duplicated there. (See any sample Compose app for an example).

The app uses a theme based on Material 2. If a migration to Material You (=3) should happen, the best time would be to do this before this ticket, as the theme definition also for compose looks a bit different between Material 2 and 3.

I've tried it before, but ended up not doing it, see #3650. (I have no really strong opinion on not using Material You - if someone else did the migration, I'd be okay with it)

@westnordost
Copy link
Member Author

#5607

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iOS necessary for iOS port
Projects
Status: Done
Development

No branches or pull requests

1 participant