Don't use disused:shop=yes on non-shops

[Discostu36]

When an amenity, healthcare facility, etc. is closed, SC adds disused:shop=yes. See, for example, here. This is adding wrong data, as the lifecycle prefix should match the former tag.

How to Reproduce

I guess this happens every time that you mark a location as vacant.

Expected Behavior

The (former) main tag of the facility should be altered by adding a disused: in front, like explained in the wiki.

Versions affected

SC 56.0, probably also later, there was no mention in the changelogs.

[Discostu36]

If you want to avoid using the value because it could be incorrect, as @matkoniecz argued in #2707 (comment), at least the key should be preserved, e.g. disused:amenity=yes.

[westnordost]

This is more of a missing feature than a bug, but I agree, it should be done. (Or, use shop=vacant after all.)

Unfortunately, the code for this is quite scattered right now and assumes that tags like disused:amenity (...office, club, craft, ... ) are not used, so this all should be handled in a newly to be defined function named e.g. fun makeDisused(tags: Tag) or similar in de/westnordost/osm/Lifecycle.kt (or similar).

(If someone wants to contribute this, start with searching for usages of "disused:shop" in the code.)

[matkoniecz]

This is more of a missing feature than a bug, but I agree, it should be done. (Or, use shop=vacant after all.)

If disused:shop=yes is bad in case of emptied amenity then surely shop=vacant is also bad?

For shop-like amenities disused:shop=yes seems not worse than disused:amenity=yes to me.

[Helium314]

For disused amenities I think it's be better to keep the value. disused:amenity=yes could also be a disused waste bin, vending machine or car park.